Open
Conversation
ernest-okot
reviewed
Apr 16, 2022
ernest-okot
reviewed
Apr 16, 2022
ernest-okot
reviewed
Apr 16, 2022
ernest-okot
reviewed
Apr 16, 2022
ernest-okot
reviewed
Apr 16, 2022
ernest-okot
requested changes
Apr 16, 2022
Collaborator
ernest-okot
left a comment
ernest-okot
left a comment
There was a problem hiding this comment.
Good job so far, just take a look at the comments I have left
ernest-okot
reviewed
Apr 20, 2022
Collaborator
ernest-okot
left a comment
ernest-okot
left a comment
There was a problem hiding this comment.
remember to squash the commits and use conventional commit messages (prefixed with feat: or fix:) to make a release and push to npm happen
Contributor
Author
|
yes i did. `referenceId` is not optional.
…---
Luigi Morel.
Software Engineer
Tel: +256 704 916 696 (WhatsApp only)
On Wed, Apr 20, 2022, 14:31 Ernest Okot ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/errors.ts
<#72 (comment)>:
> @@ -171,7 +172,7 @@ export function getError(code?: FailureReason, message?: string) {
return new UnspecifiedError(message);
}
-export function getTransactionError(transaction: Payment | Transfer) {
+export function getTransactionError(transaction: Payment | Transfer | Remit) {
const error: MtnMoMoError = getError(transaction.reason as FailureReason);
Did you check in the docs?
—
Reply to this email directly, view it on GitHub
<#72 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALR3BBP3A5T72BC7VJS35SDVF7TITANCNFSM5TPJSPOA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the remittance operation to SDK.
Fixes #14.
Please test and let me there's anything I'm missing.